fix assert of deploymentCircuitBreaker #1217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
integration
This comment was marked as outdated.
This comment was marked as outdated.
markuman
changed the title
Contributor
|
recheck |
Contributor
tremble
approved these changes
Jun 5, 2022
Contributor
tremble
left a comment
tremble
left a comment
There was a problem hiding this comment.
Run tests locally and they now pass. I'd missed that they didn't run last time.
Contributor
Contributor
|
Wow woops thanks for cleaning this up! Doesn't the PR pipeline run the integration tests? Was there a way for me to tell that it was failing? |
Member
Author
ATM not. But work for it is in progress.
basically you're place the afterwards you can run but somewhere must be also a more detailed manual for it. |
This was referenced Jun 7, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
backport-3: ecs_service deployment_circuit_breaker SUMMARY manual backport of #1215 #1217 there is no version_added, because the module already supports this feature. it was just undocumented. ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
backport-2: ecs_service deployment_circuit_breaker SUMMARY manual backport of #1215 #1217 there is no version_added, because the module already supports this feature. it was just undocumented. ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fix broken ecs_cluster integration test of #1215
cc @tremble @karcadia
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION